[
https://issues.apache.org/jira/browse/HDFS-10756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478084#comment-15478084
]
Xiao Chen commented on HDFS-10756:
----------------------------------
Thanks [~yuanbo] for the new patch! Overall looks good. Some comments from me:
- The change in {{DistributedFileSystem#getTrashRoot}}.
Could you explain more? Looking into {{DFSUtilClient#isHDFSEncryptionEnabled}},
it's checking the provider URIs. Without provider URIs the client can't contact
KMS server, and hence won't be able to get the key. I think the check is
correct.
- {{NamenodeWebHdfsMethods}}
Please stick with current coding style. Needs '{}' to wrap the case block.
- ... BaseTestHttpFSWith, it would be tricky if I add EZ test case here
Could you explain what the difficulty is? I think Andrew's HDFS-10832 may be a
good example on how to add the tests into the base class.
- Failed tests look related, likely due to the parent path change in DFS.java
- Could you also add a couple more test cases to cover getTrash when: {{/}} as
an EZ, nested EZ?
> Expose getTrashRoot to HTTPFS and WebHDFS
> -----------------------------------------
>
> Key: HDFS-10756
> URL: https://issues.apache.org/jira/browse/HDFS-10756
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: encryption, httpfs, webhdfs
> Reporter: Xiao Chen
> Assignee: Yuanbo Liu
> Attachments: HDFS-10756.001.patch, HDFS-10756.002.patch
>
>
> Currently, hadoop FileSystem API has
> [getTrashRoot|https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java#L2708]
> to determine trash directory at run time. Default trash dir is under
> {{/user/$USER}}
> For an encrypted file, since moving files between/in/out of EZs are not
> allowed, when an EZ file is deleted via CLI, it calls in to [DFS
> implementation|https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java#L2485]
> to move the file to a trash directory under the same EZ.
> This works perfectly fine for CLI users or java users who call FileSystem
> API. But for users via httpfs/webhdfs, currently there is no way to figure
> out what the trash root would be. This jira is proposing we add such
> interface to httpfs and webhdfs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
