[
https://issues.apache.org/jira/browse/HDFS-10657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15479116#comment-15479116
]
Yongjun Zhang commented on HDFS-10657:
--------------------------------------
HI [~jzhuge],
Nice catch of the issue and thanks for working on it. The patch looks good to
me.
I will commit next Monday, I will strip the white space before commit..
Thanks.
> testAclCLI.xml setfacl test should expect mask r-x
> --------------------------------------------------
>
> Key: HDFS-10657
> URL: https://issues.apache.org/jira/browse/HDFS-10657
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.6.0
> Reporter: John Zhuge
> Assignee: John Zhuge
> Priority: Minor
> Attachments: HDFS-10657.001.patch
>
>
> The following test case should expect {{mask::r-x}} ACL entry instead of
> {{mask::rwx}}:
> {code:xml}
> <description>setfacl : check inherit default ACL to dir</description>
> <test-commands>
> <command>-fs NAMENODE -mkdir /dir1</command>
> <command>-fs NAMENODE -setfacl -m
> default:user:charlie:r-x,default:group:admin:rwx /dir1</command>
> <command>-fs NAMENODE -mkdir /dir1/dir2</command>
> <command>-fs NAMENODE -getfacl /dir1/dir2</command>
> ...
> <comparator>
> <type>SubstringComparator</type>
> <expected-output>mask::rwx</expected-output>
> </comparator>
> {code}
> But why does it pass? Because the comparator type is {{SubstringComparator}}
> and it matches the wrong line {{default:mask::rwx}} in the output of
> {{getfacl}}:
> {noformat}
> # file: /dir1/dir2
> # owner: jzhuge
> # group: supergroup
> user::rwx
> user:charlie:r-x
> group::r-x
> group:admin:rwx #effective:r-x
> mask::r-x
> other::r-x
> default:user::rwx
> default:user:charlie:r-x
> default:group::r-x
> default:group:admin:rwx
> default:mask::rwx
> default:other::r-x
> {noformat}
> The comparator should match the entire line instead of just substring. Other
> comparators in {{testAclCLI.xml}} have the same problem.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
