[
https://issues.apache.org/jira/browse/HDFS-10838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15482335#comment-15482335
]
Arpit Agarwal commented on HDFS-10838:
--------------------------------------
Hi [~surendrasingh], you may have to reattach the patch with another name.
Jenkins seems to be picking up the latest file attached without looking at the
extension.
I looked at this some more and the {{lastStorageInRpc}} check will be
insufficient. We have to look into the BlockReportContext to determine when the
last report has been received. e.g. this block of code earlier on in
{{processReport}}..
{code}
if (context != null) {
storageInfo.setLastBlockReportId(context.getReportId());
if (lastStorageInRpc) {
int rpcsSeen = node.updateBlockReportContext(context);
if (rpcsSeen >= context.getTotalRpcs()) {
long leaseId = blockReportLeaseManager.removeLease(node);
{code}
I'll also take a look at this and help with updating the patch to ensure we
only update this timestamp when we are sure we have processed all storage RPCs.
> Last full block report received time for each DN should be easily discoverable
> ------------------------------------------------------------------------------
>
> Key: HDFS-10838
> URL: https://issues.apache.org/jira/browse/HDFS-10838
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: ui
> Reporter: Arpit Agarwal
> Assignee: Surendra Singh Lilhore
> Attachments: DFSAdmin-Report.png, HDFS-10838-001.patch,
> HDFS-10838.002.patch, HDFS-10838.003.patch, HDFS-10838.004.patch, NN_UI.png,
> NN_UI_relative_time.png, NN_UI_relative_time_minutes.png
>
>
> It should be easy for administrators to discover the time of last full block
> report from each DataNode.
> We can show it in the NameNode web UI or in the output of {{hdfs dfsadmin
> -report}}, or both.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
