[
https://issues.apache.org/jira/browse/HDFS-10599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15485897#comment-15485897
]
Manoj Govindassamy commented on HDFS-10599:
-------------------------------------------
Thanks for the review [~xiaobingo].
1. Yes, Report command doesn't need 'fs' option. But 'fs' being a generic
option, all Commands should work well with 'fs' option. Since DiskBalancer
methods were run directly from the TestBalancerCommand unit tests, generic
options weren't added during the run and the Commands used to fail with
unexpected option errors. So, the intention of this jira is to make the test
run DiskBalancer Commands just like the way it runs in real command line shell
via DiskBalancerCLI main and there by have access to all generic options. So,
added a unit test to prove DiskBalancer Commands can be run with GenericOptions
like "fs".
2. Thats right. Removed the out parameter from DiskBalancerCLI#dispatch. Thanks
for catching this.
Attaching v002 patch with more test comments and with redundant out argument
removed.
> DiskBalancer: Execute CLI via Shell
> ------------------------------------
>
> Key: HDFS-10599
> URL: https://issues.apache.org/jira/browse/HDFS-10599
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: balancer & mover
> Affects Versions: 3.0.0-alpha1
> Reporter: Anu Engineer
> Assignee: Manoj Govindassamy
> Attachments: HDFS-10599.001.patch
>
>
> DiskBalancer CLI invokes CLI functions directly instead of shell. This is not
> representative of how end users use it. To provide good unit test coverage,
> we need to have tests where DiskBalancer CLI is invoked via shell.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
