[
https://issues.apache.org/jira/browse/HDFS-10856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15485954#comment-15485954
]
Yiqun Lin commented on HDFS-10856:
----------------------------------
Thanks [~ajisakaa] for the suggestions.
{quote}
I'm thinking we should add eol=lf in the following lines to avoid such error
{quote}
You are right. By default way, I creat a patch in windows, it will print the
following warning:
{code}
warning: LF will be replaced by CRLF in .../BPServiceActor.java
{code}
{quote}
This should be done in a separate jira.
{quote}
+1 for this, it will make users avoid these error when they creating patches.
I had make a change {{*.java text diff=java eof=lf}}? And then I did the
dos2unix command for the output patch file. Hope my latest patch will be
successful, :).
> Update the comment of BPServiceActor$Scheduler#scheduleNextBlockReport
> ----------------------------------------------------------------------
>
> Key: HDFS-10856
> URL: https://issues.apache.org/jira/browse/HDFS-10856
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Akira Ajisaka
> Assignee: Yiqun Lin
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-10856.001.patch
>
>
> Now the interval is 6 hours by default.
> {code:title=BPServiceActor$Scheduler#scheduleNextBlockReport}
> /* say the last block report was at 8:20:14. The current report
> * should have started around 9:20:14 (default 1 hour interval).
> * If current time is :
> * 1) normal like 9:20:18, next report should be at 10:20:14
> * 2) unexpected like 11:35:43, next report should be at 12:20:14
> */
> nextBlockReportTime +=
> (((monotonicNow() - nextBlockReportTime +
> blockReportIntervalMs) /
> blockReportIntervalMs)) * blockReportIntervalMs;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
