[
https://issues.apache.org/jira/browse/HDFS-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020051#comment-13020051
]
Hadoop QA commented on HDFS-1070:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12476364/trunkLocalNameImage9.patch
against trunk revision 1092507.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.hdfs.server.datanode.TestBlockReport
org.apache.hadoop.hdfs.TestFileConcurrentReader
-1 contrib tests. The patch failed contrib unit tests.
-1 system test framework. The patch failed system test framework compile.
Test results:
https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/368//testReport/
Findbugs warnings:
https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/368//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/368//console
This message is automatically generated.
> Speedup NameNode image loading and saving by storing local file names
> ---------------------------------------------------------------------
>
> Key: HDFS-1070
> URL: https://issues.apache.org/jira/browse/HDFS-1070
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.23.0
>
> Attachments: trunkLocalNameImage.patch, trunkLocalNameImage1.patch,
> trunkLocalNameImage3.patch, trunkLocalNameImage4.patch,
> trunkLocalNameImage5.patch, trunkLocalNameImage6.patch,
> trunkLocalNameImage7.patch, trunkLocalNameImage8.patch,
> trunkLocalNameImage9.patch, trunkLocalNameImage9.patch
>
>
> Currently each inode stores its full path in the fsimage. I'd propose to
> store the local name instead. In order for each inode to identify its parent,
> all inodes in a directory tree are stored in the image in in-order. This
> proposal also requires each directory stores the number of its children in
> image.
> This proposal would bring a few benefits as pointed below and therefore
> speedup the image loading and saving.
> # Remove the overhead of converting java-UTF8 encoded local name to
> string-represented full path then to UTF8 encoded full path when saving to an
> image and vice versa when loading the image.
> # Remove the overhead of traversing the full path when inserting the inode to
> its parent inode.
> # Reduce the number of temporary java objects during the process of image
> loading or saving and therefore reduce the GC overhead.
> # Reduce the size of an image.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
