[ 
https://issues.apache.org/jira/browse/HDFS-10810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15488777#comment-15488777
 ] 

Tsz Wo Nicholas Sze commented on HDFS-10810:
--------------------------------------------

When I ran the new test testSetReplicationWhenBatchIBR without the fix, 
everything passed except that it failed at the last line 
TestFileCorruption.java:257 since getUnderReplicatedBlocksCount() returned 0.
{code}
//TestFileCorruption.java:257
      assertEquals(1, cluster.getNamesystem().getBlockManager()
          .getUnderReplicatedBlocksCount());
{code}
{code}
Running org.apache.hadoop.hdfs.TestFileCorruption
Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 25.805 sec <<< 
FAILURE! - in org.apache.hadoop.hdfs.TestFileCorruption
testSetReplicationWhenBatchIBR(org.apache.hadoop.hdfs.TestFileCorruption)  Time 
elapsed: 9.012 sec  <<< FAILURE!
java.lang.AssertionError: expected:<1> but was:<0>
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.failNotEquals(Assert.java:743)
        at org.junit.Assert.assertEquals(Assert.java:118)
        at org.junit.Assert.assertEquals(Assert.java:555)
        at org.junit.Assert.assertEquals(Assert.java:542)
        at 
org.apache.hadoop.hdfs.TestFileCorruption.testSetReplicationWhenBatchIBR(TestFileCorruption.java:257)
{code}
So it seems that everything works fine (or the unit test cannot show the bug)?

>  Setreplication removing block from underconstrcution temporarily when batch 
> IBR is enabled.
> --------------------------------------------------------------------------------------------
>
>                 Key: HDFS-10810
>                 URL: https://issues.apache.org/jira/browse/HDFS-10810
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>         Attachments: HDFS-10810-002.patch, HDFS-10810-003.patch, 
> HDFS-10810.patch
>
>
> 1)Batch IBR is enabled with number of committed blocks allowed=1
> 2) Written one block and closed the file without waiting for IBR
> 3)Setreplication called immediately on the file. 
> SO till the finalized IBR Received, this block will be marked as corrupt.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to