[
https://issues.apache.org/jira/browse/HDFS-10489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494969#comment-15494969
]
Andrew Wang commented on HDFS-10489:
------------------------------------
Thanks for revving, some review comments:
* Any reason we don't purge all usages of
{{DFSConfigKeys#DFS_ENCRYPTION_KEY_PROVIDER_URI}} from the code base? We should
try and set a good example in our tests.
* Same for
{{HdfsClientConfigKeys.DeprecatedKeys#DFS_ENCRYPTION_KEY_PROVIDER_URI}} and its
usages, we can move over to the new property.
* hdfs-default.xml, I think we can just delete the old config key and depend on
the warning message for users who are still setting the old key. Can add a
release note to this JIRA to help raise awareness too, people don't typically
diff the docs when upgrading between releases.
* In the docs, I don't think we need the new NOTE for the same reason as
previous.
These are pretty small things, so close to +1 overall. Thanks for pushing on
this Xiao!
> Deprecate dfs.encryption.key.provider.uri for HDFS encryption zones
> -------------------------------------------------------------------
>
> Key: HDFS-10489
> URL: https://issues.apache.org/jira/browse/HDFS-10489
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.6.4
> Reporter: Xiao Chen
> Assignee: Xiao Chen
> Priority: Minor
> Attachments: HDFS-10489.01.patch, HDFS-10489.02.patch,
> HDFS-10489.03.patch, HDFS-10489.04.patch
>
>
> When working on HADOOP-13155, we
> [discussed|https://issues.apache.org/jira/browse/HADOOP-13155?focusedCommentId=15315117&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15315117]
> and concluded that we should use the common config key for key provider uri.
> We can depreate the dfs. key for 3.0.0.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
