[ 
https://issues.apache.org/jira/browse/HDFS-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15500220#comment-15500220
 ] 

Rakesh R commented on HDFS-10800:
---------------------------------

Thanks [~umamaheswararao] for the patch. Overalll patch looks good, few minor 
comments.
# DFSUtil.removeOverlapBetweenStorageTypes(), its good to add {{expected}}, 
{{existing}} arguments in the javadoc
# Could you also rename the variable {{BlockMovingInfo blkInfoToMoveStorage}} 
to {{BlockMovingInfo blkMovingInfo}}
# Add a TODO to make this configurable, // how often namenode checks for new 
block movement work to satisfy storage policy
{code}
+        // Adding as attempted for movement
+        Thread.sleep(3000);
{code}
# Can we add {{terminate(1, t);}} while handling throwable exception in 
{{StoragePolicySatisfier#run()}} method.

> [SPS]: Storage Policy Satisfier daemon thread in Namenode to find the blocks 
> which were placed in other storages than what NN is expecting.
> -------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-10800
>                 URL: https://issues.apache.org/jira/browse/HDFS-10800
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: HDFS-10285
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>         Attachments: HDFS-10800-HDFS-10285-00.patch, 
> HDFS-10800-HDFS-10285-01.patch, HDFS-10800-HDFS-10285-02.patch
>
>
> This JIRA is for implementing a daemon thread called StoragePolicySatisfier 
> in nematode, which should scan the asked files blocks which were placed in 
> wrong storages in DNs. 
>  The idea is:
>       # When user called on some files/dirs for satisfyStorage policy, They 
> should have tracked in NN and then StoragePolicyDaemon thread will pick one 
> by one file and then check the blocks which might have placed in wrong 
> storage in DN than what NN is expecting it to.
>       # After checking all, it should also construct the data structures for 
> the required information to move a block from one storage to another.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to