James Clampffer updated HDFS-10874:
    Attachment: HDFS-10874.HDFS-8707.000.patch

It looks like URI was the only thing causing issues here.  I moved the whole 
URI header to hdfspp/include because it should be useful to be able to pass 
that in and out of the API anyway.

While looking at hdfs_ext.h I saw that some of the API functions weren't tagged 
LIBHDFS_EXTERNAL so I also added those.

> libhdfs++: Public API headers should not depend on internal implementation
> --------------------------------------------------------------------------
>                 Key: HDFS-10874
>                 URL: https://issues.apache.org/jira/browse/HDFS-10874
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: James Clampffer
>         Attachments: HDFS-10874.HDFS-8707.000.patch
> Public headers need to do some combination of the following: stop including 
> parts of the implementation, forward declare bits of the implementation where 
> absolutely needed, or pull the implementation into include/hdfspp if it's 
> inseparable.
> Example:
> If you want to use the C++ API and only stick include/hdfspp in the include 
> path you'll get an error when you include include/hdfspp/options.h because 
> that goes and includes common/uri.h.
> Related to the work described in HDFS-10787.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to