Kai Zheng commented on HDFS-10828:

Hi [~arpitagarwal], thanks for working on this. Having read the change, it 
looks good. A minor not introduced by this, but would be good to fix.

* In the following, it says AutoCloseable wraps ReentrantLock, which isn't 
accurate. ReentrantLock => Lock.
 * This is a wrap class of a ReentrantLock. Extending AutoCloseable
 * interface such that the users can use a try-with-resource syntax.

The patch could also be re-based.

> Fix usage of FsDatasetImpl object lock in ReplicaMap
> ----------------------------------------------------
>                 Key: HDFS-10828
>                 URL: https://issues.apache.org/jira/browse/HDFS-10828
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.8.0
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>         Attachments: HDFS-10828.01.patch, HDFS-10828.02.patch, 
> HDFS-10828.03.patch
> HDFS-10682 replaced the FsDatasetImpl object lock with a separate reentrant 
> lock but missed updating an instance ReplicaMap still uses the FsDatasetImpl.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to