[
https://issues.apache.org/jira/browse/HDFS-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020628#comment-13020628
]
Ashwin Giridharan commented on HDFS-1572:
-----------------------------------------
As per the current solution, if 'periodMS' is configured as '6 mins', then
checkpoint will happen only at 10th minute , because of 'fiveMinMS'. Instead we
can optimize these two default values, such that the wait will be happening for
only LCM('periodMS','fiveMinMS') period , rather than
MIN('periodMS','fiveMinMS')
> Checkpointer should trigger checkpoint with specified period.
> -------------------------------------------------------------
>
> Key: HDFS-1572
> URL: https://issues.apache.org/jira/browse/HDFS-1572
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Liyin Liang
> Assignee: Jakob Homan
> Priority: Blocker
> Fix For: 0.22.0
>
> Attachments: 1527-1.diff, 1572-2.diff, HDFS-1572-2.patch,
> HDFS-1572-3.patch, HDFS-1572.patch
>
>
> {code:}
> long now = now();
> boolean shouldCheckpoint = false;
> if(now >= lastCheckpointTime + periodMSec) {
> shouldCheckpoint = true;
> } else {
> long size = getJournalSize();
> if(size >= checkpointSize)
> shouldCheckpoint = true;
> }
> {code}
> {dfs.namenode.checkpoint.period} in configuration determines the period of
> checkpoint. However, with above code, the Checkpointer triggers a checkpoint
> every 5 minutes (periodMSec=5*60*1000). According to SecondaryNameNode.java,
> the first *if* statement should be:
> {code:}
> if(now >= lastCheckpointTime + 1000 * checkpointPeriod) {
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
