[ 
https://issues.apache.org/jira/browse/HDFS-10687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15508341#comment-15508341
 ] 

Hadoop QA commented on HDFS-10687:
----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
14s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
27s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 
 7s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  7m 
20s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
29s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m  
3s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
21s{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Skipped patched modules with no Java source: 
hadoop-build-tools {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
45s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
6s{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
 0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  7m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green}  7m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  7m 
19s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
1m 50s{color} | {color:orange} root: The patch generated 78 new + 0 unchanged - 
0 fixed = 78 total (was 0) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m  
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Skipped patched modules with no Java source: 
hadoop-build-tools {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m 
58s{color} | {color:red} hadoop-hdfs-project/hadoop-hdfs generated 11 new + 0 
unchanged - 0 fixed = 11 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  1m  
2s{color} | {color:red} hadoop-hdfs-project_hadoop-hdfs generated 11 new + 7 
unchanged - 0 fixed = 18 total (was 7) {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
10s{color} | {color:green} hadoop-build-tools in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 60m 40s{color} 
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
23s{color} | {color:red} The patch generated 4 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 98m 19s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs-project/hadoop-hdfs |
|  |  Useless control flow in 
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$FederationNamespaceInfoProto$Builder.maybeForceBuilderInitialization()
  At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 
3248] |
|  |  Useless control flow in 
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$GetExpiredRegistrationsRequestProto$Builder.maybeForceBuilderInitialization()
  At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 
5937] |
|  |  Useless control flow in 
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$GetNamespaceInfoRequestProto$Builder.maybeForceBuilderInitialization()
  At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 
6275] |
|  |  Useless control flow in 
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$NamenodeHeartbeatResponseProto$Builder.maybeForceBuilderInitialization()
  At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 
9190] |
|  |  Useless control flow in 
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$NamenodeMembershipEntityProto$Builder.maybeForceBuilderInitialization()
  At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 
1480] |
|  |  Useless control flow in 
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$OverrideNamenodeRegistrationRequestProto$Builder.maybeForceBuilderInitialization()
  At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 
7564] |
|  |  Useless control flow in 
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$OverrideNamenodeRegistrationResponseProto$Builder.maybeForceBuilderInitialization()
  At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 
8211] |
|  |  Useless control flow in 
org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$QueryPairProto$Builder.maybeForceBuilderInitialization()
  At HdfsServerFederationProtos.java: At HdfsServerFederationProtos.java:[line 
4007] |
|  |  Exception is caught when Exception is not thrown in 
org.apache.hadoop.hdfs.server.federation.store.FederationMembershipStateStoreUtils.aggregateFederationNamespaceInfo(FederationMembershipStateStore,
 String)  At FederationMembershipStateStoreUtils.java:is not thrown in 
org.apache.hadoop.hdfs.server.federation.store.FederationMembershipStateStoreUtils.aggregateFederationNamespaceInfo(FederationMembershipStateStore,
 String)  At FederationMembershipStateStoreUtils.java:[line 65] |
|  |  org.apache.hadoop.hdfs.server.federation.store.FederationNamespaceInfo 
defines compareTo(FederationNamespaceInfo) and uses Object.equals()  At 
FederationNamespaceInfo.java:Object.equals()  At 
FederationNamespaceInfo.java:[line 70] |
|  |  Exception is caught when Exception is not thrown in 
org.apache.hadoop.hdfs.server.federation.store.protocol.impl.pb.FederationProtocolPBTranslator.getBuilder()
  At FederationProtocolPBTranslator.java:is not thrown in 
org.apache.hadoop.hdfs.server.federation.store.protocol.impl.pb.FederationProtocolPBTranslator.getBuilder()
  At FederationProtocolPBTranslator.java:[line 71] |
| Failed junit tests | hadoop.hdfs.server.blockmanagement.TestReplicationPolicy 
|
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:9560f25 |
| JIRA Issue | HDFS-10687 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12829467/HDFS-10467-HDFS-10687-001.patch
 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  xml  findbugs  checkstyle  cc  |
| uname | Linux d9fc9b4e7e4b 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 
20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh 
|
| git revision | trunk / e80386d |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-HDFS-Build/16817/artifact/patchprocess/diff-checkstyle-root.txt
 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HDFS-Build/16817/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
 |
| javadoc | 
https://builds.apache.org/job/PreCommit-HDFS-Build/16817/artifact/patchprocess/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HDFS-Build/16817/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HDFS-Build/16817/testReport/ |
| asflicense | 
https://builds.apache.org/job/PreCommit-HDFS-Build/16817/artifact/patchprocess/patch-asflicense-problems.txt
 |
| modules | C: hadoop-build-tools hadoop-hdfs-project/hadoop-hdfs U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-HDFS-Build/16817/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Federation Membership State Store internal APIs
> -----------------------------------------------
>
>                 Key: HDFS-10687
>                 URL: https://issues.apache.org/jira/browse/HDFS-10687
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: fs
>            Reporter: Inigo Goiri
>            Assignee: Jason Kace
>         Attachments: HDFS-10467-HDFS-10687-001.patch
>
>
> The Federation Membership State encapsulates the information about the 
> Namenodes of each sub-cluster that are participating in Federation. The 
> information includes addresses for RPC, Web. This information is stored in 
> the State Store and later used by the Router to find data in the federation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to