[
https://issues.apache.org/jira/browse/HDFS-10631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15508531#comment-15508531
]
Hadoop QA commented on HDFS-10631:
----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 18m
35s{color} | {color:green} HDFS-10467 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
47s{color} | {color:green} HDFS-10467 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
28s{color} | {color:green} HDFS-10467 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
1s{color} | {color:green} HDFS-10467 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
19s{color} | {color:green} HDFS-10467 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
57s{color} | {color:green} HDFS-10467 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} HDFS-10467 passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 26s{color} | {color:orange} hadoop-hdfs-project/hadoop-hdfs: The patch
generated 29 new + 0 unchanged - 0 fixed = 29 total (was 0) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m
2s{color} | {color:red} hadoop-hdfs-project/hadoop-hdfs generated 7 new + 0
unchanged - 0 fixed = 7 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 66m 34s{color}
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
23s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 98m 55s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs-project/hadoop-hdfs |
| | Found reliance on default encoding in
org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreZooKeeperImpl.writeNode(String,
String, boolean, boolean):in
org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreZooKeeperImpl.writeNode(String,
String, boolean, boolean): String.getBytes() At
StateStoreZooKeeperImpl.java:[line 402] |
| | Inconsistent synchronization of
org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreZooKeeperImpl.zkAuths;
locked 50% of time Unsynchronized access at StateStoreZooKeeperImpl.java:50%
of time Unsynchronized access at StateStoreZooKeeperImpl.java:[line 98] |
| | Inconsistent synchronization of
org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreZooKeeperImpl.zkHost;
locked 50% of time Unsynchronized access at StateStoreZooKeeperImpl.java:50%
of time Unsynchronized access at StateStoreZooKeeperImpl.java:[line 94] |
| | Redundant nullcheck of znode, which is known to be non-null in
org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreZooKeeperImpl.deleteAll(Class)
Redundant null check at StateStoreZooKeeperImpl.java:is known to be non-null
in
org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreZooKeeperImpl.deleteAll(Class)
Redundant null check at StateStoreZooKeeperImpl.java:[line 490] |
| | Redundant nullcheck of znode, which is known to be non-null in
org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreZooKeeperImpl.getAll(Class)
Redundant null check at StateStoreZooKeeperImpl.java:is known to be non-null
in
org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreZooKeeperImpl.getAll(Class)
Redundant null check at StateStoreZooKeeperImpl.java:[line 336] |
| | Found reliance on default encoding in
org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreZooKeeperImpl$ZKData.getData():in
org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreZooKeeperImpl$ZKData.getData():
new String(byte[]) At StateStoreZooKeeperImpl.java:[line 264] |
| | Should
org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreZooKeeperImpl$ZKData
be a _static_ inner class? At StateStoreZooKeeperImpl.java:inner class? At
StateStoreZooKeeperImpl.java:[lines 259-264] |
| Failed junit tests | hadoop.hdfs.server.blockmanagement.TestBlockManager |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:9560f25 |
| JIRA Issue | HDFS-10631 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12829479/HDFS-10631-HDFS-10467-001.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 66a87e72a494 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28
20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | HDFS-10467 / 382dff7 |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/16819/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HDFS-Build/16819/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
|
| unit |
https://builds.apache.org/job/PreCommit-HDFS-Build/16819/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/16819/testReport/ |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
hadoop-hdfs-project/hadoop-hdfs |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/16819/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Federation State Store ZooKeeper implementation
> -----------------------------------------------
>
> Key: HDFS-10631
> URL: https://issues.apache.org/jira/browse/HDFS-10631
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: fs
> Reporter: Inigo Goiri
> Assignee: Jason Kace
> Attachments: HDFS-10631-HDFS-10467-001.patch
>
>
> State Store implementation using ZooKeeper.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
