James Clampffer commented on HDFS-10874:

Thanks for the review Bob.  I'll commit/resolve momentarily.

bq. Perhaps as another task, we should ensure that the tools and examples build 
using just the public headers.
I agree.  As part of that it'd be good to make sure that headers from other 
directories aren't being implicitly added to the include paths for building the 
tools and examples so it errors when tools are written to use them.  How about 
we generalize HDFS-10787 to cover that work?

> libhdfs++: Public API headers should not depend on internal implementation
> --------------------------------------------------------------------------
>                 Key: HDFS-10874
>                 URL: https://issues.apache.org/jira/browse/HDFS-10874
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: James Clampffer
>            Assignee: James Clampffer
>         Attachments: HDFS-10874.HDFS-8707.000.patch
> Public headers need to do some combination of the following: stop including 
> parts of the implementation, forward declare bits of the implementation where 
> absolutely needed, or pull the implementation into include/hdfspp if it's 
> inseparable.
> Example:
> If you want to use the C++ API and only stick include/hdfspp in the include 
> path you'll get an error when you include include/hdfspp/options.h because 
> that goes and includes common/uri.h.
> Related to the work described in HDFS-10787.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to