Inigo Goiri commented on HDFS-10882:

[~jakace], a few comments:
* Could you extend the comment for {{FederationProtocolBase}}?
* In {{FederationProtocolFactory}}, could we use record and clazz instead of 
entity/entry and entityType? Can you also add a javadoc for {{useProtobuf()}}.
* Do we need the constructor in {{FederationPBHelper}}?
* In general, the PBHelper is a little different to what HDFS has. However, 
this matches the YARN approach; ideally, we should use the YARN 
{{RecordFactory}} but as this is not in commons, this is the closest approach.
* Not sure what to do about the Federation prefix in classes like 
FederationPBHelper. Kind of superfluous.

> Federation State Store Interface API
> ------------------------------------
>                 Key: HDFS-10882
>                 URL: https://issues.apache.org/jira/browse/HDFS-10882
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: fs
>            Reporter: Jason Kace
>            Assignee: Jason Kace
>         Attachments: HDFS-10882-HDFS-10467-001.patch, 
> HDFS-10882-HDFS-10467-002.patch
> The minimal classes and interfaces required to create state store internal 
> data APIs using protobuf serialization.  This is a pre-requisite for higher 
> level APIs such as the registration API and the mount table API.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to