[ 
https://issues.apache.org/jira/browse/HDFS-10881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15514441#comment-15514441
 ] 

Inigo Goiri commented on HDFS-10881:
------------------------------------

[~jakace], version 003 of the patch looks mostly OK.

A couple comments:
* Extend the javadoc for {{FederationStateStoreService}} to give the general 
idea.
* A couple entity/entities references in the comments should move to records.
* There are a few unused imports (checkstyles).
* The comment in {{StateStoreBase}} should be a little more "HTML-like".
* In {{StateStoreBase}}, extract the function calls for debuggability (e.g., 
{{result.getData()}} and 
{{FederationProtocolFactory.getReferenceClass(record)}})
* Not sure why checkstyle didn't complain but it's missing a space between 
StateStoreDriver  and {:
{code}
public abstract class StateStoreBase implements StateStoreDriver {
{code}

> Federation State Store Driver API
> ---------------------------------
>
>                 Key: HDFS-10881
>                 URL: https://issues.apache.org/jira/browse/HDFS-10881
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: fs
>            Reporter: Jason Kace
>            Assignee: Jason Kace
>         Attachments: HDFS-10881-HDFS-10467-001.patch, 
> HDFS-10881-HDFS-10467-002.patch, HDFS-10881-HDFS-10467-003.patch
>
>
> The API interfaces and minimal classes required to support a state store data 
> backend such as ZooKeeper or a file system.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to