Lei (Eddy) Xu commented on HDFS-10637:

bq. Can you confirm which one are you referring to?

Sure. I mean you can remove {{FsVolumeImpl#currentDir}} as a class member, as 
it can be derived from {{FsVolumeImpl#storageLocation}}. 

bq. FsDatasetSpi#getFileInFinalizedDir().

It still assumes {{FsDatasetSpi}} is backed by {{java.io.File}}.  If this is 
only used by tests, can you use {{FsDatasetTestUtils#getBlockFile}} and 
{{#getMetaFile}}, as they are in the test package. So that {{FsDatasetSpi}} is 
clean from {{java.io.File}}?


> Modifications to remove the assumption that FsVolumes are backed by 
> java.io.File.
> ---------------------------------------------------------------------------------
>                 Key: HDFS-10637
>                 URL: https://issues.apache.org/jira/browse/HDFS-10637
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, fs
>            Reporter: Virajith Jalaparti
>            Assignee: Virajith Jalaparti
>         Attachments: HDFS-10637.001.patch, HDFS-10637.002.patch, 
> HDFS-10637.003.patch, HDFS-10637.004.patch, HDFS-10637.005.patch, 
> HDFS-10637.006.patch, HDFS-10637.007.patch, HDFS-10637.008.patch
> Modifications to {{FsVolumeSpi}} and {{FsVolumeImpl}} to remove references to 
> {{java.io.File}}.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to