[ 
https://issues.apache.org/jira/browse/HDFS-10869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15515734#comment-15515734
 ] 

Brahma Reddy Battula commented on HDFS-10869:
---------------------------------------------

Thanks for for reporting this issue..

Patch looks good to me.. 
one minor nit : 
can you please removed unused imports?



> Unused method checkId() in InodeId.java file 
> ---------------------------------------------
>
>                 Key: HDFS-10869
>                 URL: https://issues.apache.org/jira/browse/HDFS-10869
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: Jagadesh Kiran N
>            Assignee: Jagadesh Kiran N
>         Attachments: HDFS-10869.patch
>
>
> The following method in InodeId.java is not used anywhere , We can remove the 
> code 
> {code}
> public static void checkId(long requestId, INode inode)
>       throws FileNotFoundException {
>     if (requestId != HdfsConstants.GRANDFATHER_INODE_ID && requestId != 
> inode.getId()) {
>       throw new FileNotFoundException(
>           "ID mismatch. Request id and saved id: " + requestId + " , "
>               + inode.getId() + " for file " + inode.getFullPathName());
>     }
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to