[
https://issues.apache.org/jira/browse/HDFS-10843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15517389#comment-15517389
]
Hudson commented on HDFS-10843:
-------------------------------
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10480 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/10480/])
HDFS-10843. Update space quota when a UC block is completed rather than (shv:
rev a5bb88c8e0fd4bd19b6d377fecbe1d2d441514f6)
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirAttrOp.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestDiskspaceQuotaUpdate.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Namesystem.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
> Quota Feature Cached Size != Computed Size When Block Committed But Not
> Completed
> ---------------------------------------------------------------------------------
>
> Key: HDFS-10843
> URL: https://issues.apache.org/jira/browse/HDFS-10843
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs, namenode
> Affects Versions: 2.6.0
> Reporter: Erik Krogen
> Assignee: Erik Krogen
> Fix For: 2.7.4
>
> Attachments: HDFS-10843-branch-2.005.patch,
> HDFS-10843-branch-2.7.005.patch, HDFS-10843.000.patch, HDFS-10843.001.patch,
> HDFS-10843.002.patch, HDFS-10843.003.patch, HDFS-10843.004.patch,
> HDFS-10843.005.patch
>
>
> Currently when a block has been committed but has not yet been completed, the
> cached size (used for the quota feature) of the directory containing that
> block differs from the computed size. This results in log messages of the
> following form:
> bq. ERROR namenode.NameNode
> (DirectoryWithQuotaFeature.java:checkStoragespace(141)) - BUG: Inconsistent
> storagespace for directory /TestQuotaUpdate. Cached = 512 != Computed = 8192
> When a block is initially started under construction, the used space is
> conservatively set to a full block. When the block is committed, the cached
> size is updated to the final size of the block. However, the calculation of
> the computed size uses the full block size until the block is completed, so
> in the period where the block is committed but not completed they disagree.
> To fix this we need to decide which is correct and fix the other to match. It
> seems to me that the cached size is correct since once the block is committed
> its size will not change.
> This can be reproduced using the following steps:
> - Create a directory with a quota
> - Start writing to a file within this directory
> - Prevent all datanodes to which the file is written from communicating the
> corresponding BlockReceivedAndDeletedRequestProto to the NN temporarily (i.e.
> simulate a transient network partition/delay)
> - During this time, call DistributedFileSystem.getContentSummary() on the
> directory with the quota
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
