[
https://issues.apache.org/jira/browse/HDFS-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15517655#comment-15517655
]
Manoj Govindassamy edited comment on HDFS-9850 at 9/23/16 9:43 PM:
-------------------------------------------------------------------
Thanks for the review [~eddyxu].
* Thats right, there are 2 cases in getFsVolumeReference(). But, for the caller
who is getting the case 2 -- CCE, should that be treated as volume existence or
non-existence ? I assumed non-existence for the real use and so logging it and
returning null eventually. But, i am ok with throwing CCE also and let the
caller handle it in whatever way he wants.
* Test is using {{ClusterBuilder#build}} and it already has
{{cluster.waitActive()}}
* DiskBalancer#copyBLocks is already holding vol reference under this call
{{FsDatasetImpl#moveBlockAcrossVolumes}} and the reference is released once a
block move is completed. Holding reference only for the current block move and
re-grabbing it for the next block move goes well with other competing
operations for the reference. Else, we might starve them.
was (Author: manojg):
* Thats right, there are 2 cases in getFsVolumeReference(). But, for the caller
who is getting the case 2 -- CCE, should that be treated as volume existence or
non-existence ? I assumed non-existence for the real use and so logging it and
returning null eventually. But, i am ok with throwing CCE also and let the
caller handle it in whatever way he wants.
* Test is using {{ClusterBuilder#build}} and it already has
{{cluster.waitActive()}}
* DiskBalancer#copyBLocks is already holding vol reference under this call
{{FsDatasetImpl#moveBlockAcrossVolumes}} and the reference is released once a
block move is completed. Holding reference only for the current block move and
re-grabbing it for the next block move goes well with other competing
operations for the reference. Else, we might starve them.
> DiskBalancer : Explore removing references to FsVolumeSpi
> ----------------------------------------------------------
>
> Key: HDFS-9850
> URL: https://issues.apache.org/jira/browse/HDFS-9850
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: balancer & mover
> Affects Versions: 3.0.0-alpha2
> Reporter: Anu Engineer
> Assignee: Manoj Govindassamy
> Attachments: HDFS-9850.001.patch
>
>
> In HDFS-9671, [~arpitagarwal] commented that we should explore the
> possibility of removing references to FsVolumeSpi at any point and only deal
> with storage ID. We are not sure if this is possible, this JIRA is to explore
> if that can be done without issues.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
