[ 
https://issues.apache.org/jira/browse/HDFS-10903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524298#comment-15524298
 ] 

Xiaoyu Yao edited comment on HDFS-10903 at 9/26/16 9:58 PM:
------------------------------------------------------------

Thanks [~liuml07] for reporting this and [~vagarychen] for posting the patch. 
The change looks good to me. 
Can you also fix the "io.file.buffer.zie" usage in 
o.a.h.fs.contract.ContractTestUtils.java? +1 after that is fixed. 

Also, we should move this JIRA from Hadoop HDFS to Hadoop Common.


was (Author: xyao):
Thanks [~liuml07] for reporting this and [~vagarychen] for posting the patch. 
The change looks good to me. 
Can you also fix the "io.file.buffer.zie" usage in 
o.a.h.fs.contract.ContractTestUtils.java? +1 after that is fixed. 

> Replace config key literal strings with config key names II: hadoop hdfs
> ------------------------------------------------------------------------
>
>                 Key: HDFS-10903
>                 URL: https://issues.apache.org/jira/browse/HDFS-10903
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Mingliang Liu
>            Assignee: Chen Liang
>            Priority: Minor
>         Attachments: HADOOP-13644.001.patch
>
>
> In *Hadoop HDFS*, there are some places that use config key literal strings 
> instead of config key names, e.g.
> {code:title=IOUtils.java}
>     copyBytes(in, out, conf.getInt("io.file.buffer.size", 4096), true);
> {code}
> We should replace places like this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to