[
https://issues.apache.org/jira/browse/HDFS-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524718#comment-15524718
]
Manoj Govindassamy commented on HDFS-9850:
------------------------------------------
Thanks for the review and comments [~anu]. Will be uploading the comments
incorporated patch soon.
1. Done. Made use of private method getFsVolume(), just like other places.
2. Done. Restored "Disk Balancer -" in the removed logs and in the new logs.
Even if you don't have these explicit signature in the logging, they already
carry file name from where the logging is happening and here in this case it
will be DiskBalancer.java, which can also be used for grepping
3. Done. Restored Volume path in the error message. True volume path when
available can be used for error logging for they are much more easier to read.
4. Done. Corrected the method comments.
5. Done. Removed the unnecessary setExitFlag() calls.
6. Done. Removed the newly introduced interface method. Rather implemented as a
new private method in DiskBalancer using the already available
getVolumeReferences().
7. Done. Added the assert for reconfigure error.
8. Done. Test now checks for the error message prefix also.
> DiskBalancer : Explore removing references to FsVolumeSpi
> ----------------------------------------------------------
>
> Key: HDFS-9850
> URL: https://issues.apache.org/jira/browse/HDFS-9850
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: balancer & mover
> Affects Versions: 3.0.0-alpha2
> Reporter: Anu Engineer
> Assignee: Manoj Govindassamy
> Attachments: HDFS-9850.001.patch, HDFS-9850.002.patch
>
>
> In HDFS-9671, [~arpitagarwal] commented that we should explore the
> possibility of removing references to FsVolumeSpi at any point and only deal
> with storage ID. We are not sure if this is possible, this JIRA is to explore
> if that can be done without issues.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
