[
https://issues.apache.org/jira/browse/HDFS-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15527010#comment-15527010
]
Anu Engineer edited comment on HDFS-10900 at 9/28/16 2:16 AM:
--------------------------------------------------------------
My sincere apologies my comment was so cryptic.
There was a checkin in the tree that changed the Apache Logo. This has broken
the whole site rendering. I applied you patch and was testing it and noticed
that it was broken completely. I wanted to file a separate JIRA for that issue
before I commit this code.
Please note: This has nothing to do with your change, that I why I mentioned
that I will check that in later. Without being able to render the page
correctly, I have no way of verifying your change. So I am holding off on
committing this. We will either backout the change in trunk (the logo change)
or someone with right CSS skills will fix it. I would like to commit your
changes after that.
To see this issue yourself , you might want to run
# mvn site:site
# mvn site:stage -DstagingDirectory=/tmp/mysite
# open /tmp/mysite/hadoop-project/index.html
Then browse around the pages -- especially the hadoop commands and
HDFSDiskBalancer page. Again I am +1 on this change, but I want to commit when
the code base is in a better shape.
was (Author: anu):
My sincere apologies my comment was so cryptic.
There was a checkin in the tree that changed the Apache Logo. This has broken
the whole site rendering. I applied you patch and was testing it and noticed
that it was broken completely. I wanted to file a separate JIRA for that issue
before I commit this code.
Please note: This has nothing to do with your change, that I why I mentioned
that I will check that in later. Without being able to render the page
correctly, I have no way of verifying your change. So I am holding off on
committing this. We will either backout the change in trunk (the logo change)
or someone with right CSS skills will fix it. I would like to commit your
changes after that.
To see this issue yourself , you might want to run
# mvn site:site
# mvn site:stage -DstagingDirectory=/tmp/mysite
# open /tmp/mysite/hadoop-project/index.html
Then browser around the pages -- especially the hadoop commands and
HDFSDiskBalancer page. Again I am +1 on this change, but I want to commit when
the code base is in a better shape.
> DiskBalancer: Complete the documents for the report command
> -----------------------------------------------------------
>
> Key: HDFS-10900
> URL: https://issues.apache.org/jira/browse/HDFS-10900
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: documentation
> Reporter: Yiqun Lin
> Assignee: Yiqun Lin
> Priority: Minor
> Fix For: 3.0.0-alpha2
>
> Attachments: HDFS-10900.001.patch
>
>
> Now the documemnts of the command {{hdfs diskbalancer -report}} look not
> completed. Two minors:
> * The usage of {{hdfs diskbalancer -report}} is missing in {{HDFSCommands.md}}
> * One subcommand of report command {{hdfs diskbalancer -report -top}} is
> missing in {{HDFSDiskBalancer.md}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]