[ 
https://issues.apache.org/jira/browse/HDFS-10810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530236#comment-15530236
 ] 

Mingliang Liu commented on HDFS-10810:
--------------------------------------

Thanks [~brahmareddy]. That's true that [HDFS-10666] has not addressed all the 
places that use fixed time sleep for waiting. It is still an in-progress JIRA 
and needs a lot of work. If you can file/work on new sub-tasks, I'm happy to 
review. The intermittently failing ones are of high priority.

The change in the v3 patch is overall good. I'd like to confirm my thought is 
correct - the last {{getUnderReplicatedBlocksCount()}} and 
{{getMissingBlocksCount}} assertions are actually the final consistent state. 
That is, the UnderReplicatedBlocksCount will always be 1 and MissingBlocksCount 
always be 0 after they reach their respective values. If only there is a way to 
test this.

>  Setreplication removing block from underconstrcution temporarily when batch 
> IBR is enabled.
> --------------------------------------------------------------------------------------------
>
>                 Key: HDFS-10810
>                 URL: https://issues.apache.org/jira/browse/HDFS-10810
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>         Attachments: HDFS-10810-002.patch, HDFS-10810-003.patch, 
> HDFS-10810.patch
>
>
> 1)Batch IBR is enabled with number of committed blocks allowed=1
> 2) Written one block and closed the file without waiting for IBR
> 3)Setreplication called immediately on the file. 
> So till the finalized IBR Received, block will not be added to 
> {{neededReconstruction}} since following check will be {{false}} as block is 
> not marked as complete.
> {code}
> if (isNeededReconstruction(block, repl.liveReplicas())) {
>         neededReconstruction.update(block, repl.liveReplicas(),
>             repl.readOnlyReplicas(), repl.decommissionedAndDecommissioning(),
>             curExpectedReplicas, curReplicasDelta, expectedReplicasDelta);
>       }.{code}
> Hence block will not marked as under-replicated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to