[ 
https://issues.apache.org/jira/browse/HDFS-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021879#comment-13021879
 ] 

Suresh Srinivas commented on HDFS-1840:
---------------------------------------

Minor comments:
# For test configurability instead of new config option, I prefer using a 
package private method, with comments "to be used for testing".
# Instead of fragmented explanation of how the grace period works, complete 
description of the timeout functionality either in javadoc of class of run 
method would be better.


> Terminate LeaseChecker when all writing files are closed.
> ---------------------------------------------------------
>
>                 Key: HDFS-1840
>                 URL: https://issues.apache.org/jira/browse/HDFS-1840
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs client
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h1840_20110418.patch, h1840_20110419.patch
>
>
> In {{DFSClient}}, when there are files opened for write, a {{LeaseChecker}} 
> thread is started for updating the leases periodically.  However, it never 
> terminates when when all writing files are closed.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to