[ 
https://issues.apache.org/jira/browse/HDFS-10908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15536643#comment-15536643
 ] 

Wei-Chiu Chuang commented on HDFS-10908:
----------------------------------------

LGTM. Test case not needed since it's a log message only improvement.

> Improve StripedBlockReader#createBlockReader error logging
> ----------------------------------------------------------
>
>                 Key: HDFS-10908
>                 URL: https://issues.apache.org/jira/browse/HDFS-10908
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: erasure-coding
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Wei-Chiu Chuang
>            Assignee: Manoj Govindassamy
>            Priority: Minor
>         Attachments: HDFS-10908.01.patch
>
>
> In {{StripedBlockReader#createBlockReader}} if any IOException is thrown, the 
> error is logged at debug level and then returns a null. This means in a 
> typical configuration an NPE may be thrown without logging a cause if the 
> StripedBlockReader object is accessed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to