[ https://issues.apache.org/jira/browse/HDFS-10745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15547335#comment-15547335 ]
Konstantin Shvachko commented on HDFS-10745: -------------------------------------------- Sorry, just noticed one more thing. In {{abandonBlock()}} the resolution {{dir.resolvePath()}} should be done under the lock, not outside. Checked trunk, it is done there inside {{FSDirWriteFileOp}} and therefore under the lock automatically. > Directly resolve paths into INodesInPath > ---------------------------------------- > > Key: HDFS-10745 > URL: https://issues.apache.org/jira/browse/HDFS-10745 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs > Reporter: Daryn Sharp > Assignee: Daryn Sharp > Fix For: 2.8.0, 3.0.0-alpha1 > > Attachments: HDFS-10745-branch-2.7.01.patch, > HDFS-10745-branch-2.7.02.patch, HDFS-10745-branch-2.7.03.patch, > HDFS-10745-branch-2.7.04.patch, HDFS-10745-branch-2.7.05.patch, > HDFS-10745-branch-2.7.patch, HDFS-10745.2.patch, HDFS-10745.branch-2.patch, > HDFS-10745.patch > > > The intermediate resolution to a string, only to be decomposed by > {{INodesInPath}} back into a byte[][] can be eliminated by resolving directly > to an IIP. The IIP will contain the resolved path if required. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org