[
https://issues.apache.org/jira/browse/HDFS-10922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15549350#comment-15549350
]
Xiaoyu Yao edited comment on HDFS-10922 at 10/5/16 5:20 PM:
------------------------------------------------------------
bq. Now working on #4 about namenode restart. One question, the patch modified
both common and hdfs projects, is it OK to use just single 1 patch ?
Good catch, [~cheersyang]. Let's use this ticket for hdfs only changes in #4.
That should be landed in {{o.a.h.hdfs.TestHDFSTrash}}
I opened a new ticket HADOOP-13686 for #1-3. I notice the permission test for
#1 is added for only hdfs. Can you move that to hadoop-common and attach the
updated patch in HADOOP-13686? This way, we will have better coverage than
having the test only for hdfs.
was (Author: xyao):
bq. Now working on #4 about namenode restart. One question, the patch modified
both common and hdfs projects, is it OK to use just single 1 patch ?
Good catch, [~cheersyang]. Let's have a separate ticket for the hdfs changes
for #4. That should be landed in {{o.a.h.hdfs.TestHDFSTrash}}
I will move this ticket from hadoop-hdfs to hadoop-common for #1-3 only. I
notice the permission test for #1 is added for only hdfs. Can you move the test
to hadoop-common as the behavior should not be specific to hdfs?
> Adding additional unit tests for Trash
> --------------------------------------
>
> Key: HDFS-10922
> URL: https://issues.apache.org/jira/browse/HDFS-10922
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Xiaoyu Yao
> Assignee: Weiwei Yang
> Attachments: HDFS-10922.02.patch, HDFS-10922.03.patch,
> HDFS-10922.04.patch, HDFS-10922.05.patch, HDFS-10922.06.patch
>
>
> This ticket is opened to track adding unit tests for Trash.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
