[
https://issues.apache.org/jira/browse/HDFS-10801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15553458#comment-15553458
]
Uma Maheswara Rao G commented on HDFS-10801:
--------------------------------------------
Thank you [~rakeshr] for working on this.
Overall patch looks good to me. I have few minor comments though.
* Code piece
{code}
+message BlockStorageMovementProto {
+ required BlockProto block = 1;
+ required DatanodeInfosProto sourceDnInfos = 2;
+ required DatanodeInfosProto targetDnInfos = 3;
+ required StorageTypesProto sourceStorageTypes = 4;
+ required StorageTypesProto targetStorageTypes = 5;
+}
{code}
Can you please check the variable ordering consistent? BockMovingInfo toString
also has different ordering. It would be good if we follow consistent ordering.
* BlockStorageMovementCommand: I would like to see javadoc for the variables
and methods here. Explaining a bit about trackID makes more clear.
* processBlockMovingTasks: I would like to see adding comment by drafting
overall processing idea here. I am fine if you want to add in other place, but
you can refer link
> [SPS]: Protocol buffer changes for sending storage movement commands from NN
> to DN
> -----------------------------------------------------------------------------------
>
> Key: HDFS-10801
> URL: https://issues.apache.org/jira/browse/HDFS-10801
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Affects Versions: HDFS-10285
> Reporter: Uma Maheswara Rao G
> Assignee: Rakesh R
> Attachments: HDFS-10801-HDFS-10285-00.patch
>
>
> This JIRA is for tracking the work of protocol buffer changes for sending the
> storage movement commands from NN to DN
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
