[ https://issues.apache.org/jira/browse/HDFS-10985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mingliang Liu updated HDFS-10985: --------------------------------- Description: {{TestZKFailoverController#testGracefulFailoverMultipleZKfcs}} uses fixed time sleep before assertions. This may fail sometimes though 10 seconds are generally long enough. I think we can use {{GenericTestUtils.waitFor()}} to retry the assertions. If this makes sense, we can address all other places in {{TestZKFailoverController}}, including {{testGracefulFailover}} and {{testDontFailoverToUnhealthyNode}}. was:{{TestZKFailoverController#testGracefulFailoverMultipleZKfcs}} uses fixed time sleep before assertions. This may fail sometimes though 10 seconds are generally long enough. I think we can use {{GenericTestUtils.waitFor()}} to retry the assertions. > o.a.h.ha.TestZKFailoverController should not use fixed time sleep before > assertsions > ------------------------------------------------------------------------------------ > > Key: HDFS-10985 > URL: https://issues.apache.org/jira/browse/HDFS-10985 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ha, test > Reporter: Mingliang Liu > Assignee: Mingliang Liu > Priority: Minor > Attachments: HDFS-10985.000.patch > > > {{TestZKFailoverController#testGracefulFailoverMultipleZKfcs}} uses fixed > time sleep before assertions. This may fail sometimes though 10 seconds are > generally long enough. I think we can use {{GenericTestUtils.waitFor()}} to > retry the assertions. > If this makes sense, we can address all other places in > {{TestZKFailoverController}}, including {{testGracefulFailover}} and > {{testDontFailoverToUnhealthyNode}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org