[
https://issues.apache.org/jira/browse/HDFS-10985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15562046#comment-15562046
]
Steve Loughran commented on HDFS-10985:
---------------------------------------
makes a lot of sense; lets put it in and see if the itermittent jenkins
failures go away. If not, we can tune it further
+1
Patch doesn't apply to branch-2.8 BTW; I'll leave you to sort that out before
you commit it there
> o.a.h.ha.TestZKFailoverController should not use fixed time sleep before
> assertsions
> ------------------------------------------------------------------------------------
>
> Key: HDFS-10985
> URL: https://issues.apache.org/jira/browse/HDFS-10985
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, test
> Reporter: Mingliang Liu
> Assignee: Mingliang Liu
> Priority: Minor
> Attachments: HDFS-10985.000.patch
>
>
> {{TestZKFailoverController#testGracefulFailoverMultipleZKfcs}} uses fixed
> time sleep before assertions. This may fail sometimes though 10 seconds are
> generally long enough. I think we can use {{GenericTestUtils.waitFor()}} to
> retry the assertions.
> If this makes sense, we can address all other places in
> {{TestZKFailoverController}}, including {{testGracefulFailover}} and
> {{testDontFailoverToUnhealthyNode}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
