[ 
https://issues.apache.org/jira/browse/HDFS-10985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563210#comment-15563210
 ] 

Steve Loughran commented on HDFS-10985:
---------------------------------------

+1

> o.a.h.ha.TestZKFailoverController should not use fixed time sleep before 
> assertions
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-10985
>                 URL: https://issues.apache.org/jira/browse/HDFS-10985
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, test
>            Reporter: Mingliang Liu
>            Assignee: Mingliang Liu
>            Priority: Minor
>         Attachments: HDFS-10985-branch-2.8.001.patch, HDFS-10985.000.patch, 
> HDFS-10985.001.patch
>
>
> {{TestZKFailoverController#testGracefulFailoverMultipleZKfcs}} uses fixed 
> time sleep before assertions. This may fail sometimes though 10 seconds are 
> generally long enough. I think we can use {{GenericTestUtils.waitFor()}} to 
> retry the assertions.
> This is also true to {{TestZKFailoverController#testGracefulFailover}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to