[ https://issues.apache.org/jira/browse/HDFS-10638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15566888#comment-15566888 ]
Virajith Jalaparti commented on HDFS-10638: ------------------------------------------- The checkstyle warnings are due to moving (existing) code. The failing test cases are not related to the patch, and seem spurious. Both run successfully, locally. No new tests were added as the patch (1) mainly replaces usage of {{StorageLocation::getFile}} with {{StorageLocation::getURI}}, and {{StorageLocation}}, and (2) moves code ({{makeBlockPoolDataDir}}) to a new location. Existing tests (e.g., {{TestDataNodeHotSwapVolumes}}) already test these code paths. > Modifications to remove the assumption that StorageLocation is associated > with java.io.File in Datanode. > -------------------------------------------------------------------------------------------------------- > > Key: HDFS-10638 > URL: https://issues.apache.org/jira/browse/HDFS-10638 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: datanode, fs > Reporter: Virajith Jalaparti > Assignee: Virajith Jalaparti > Attachments: HDFS-10638.001.patch, HDFS-10638.002.patch, > HDFS-10638.003.patch, HDFS-10638.004.patch > > > Changes to ensure that {{StorageLocation}} need not be associated with a > {{java.io.File}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org