[ 
https://issues.apache.org/jira/browse/HDFS-10905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571467#comment-15571467
 ] 

Yuanbo Liu commented on HDFS-10905:
-----------------------------------

[~jojochuang] {{DataStreamer#createBlockOutputStream}} is based on 
{{Sender#writeBlock}} while {{DataStreamer#transfer}} and 
{{StreamerStreams#sendTransferBlock}} are based on {{Sender#transferBlock}}. So 
the code won't be decreased as much as we expect.
Anyway I'll try to refactor it and upload a patch for this issue later.

> Refactor DataStreamer#createBlockOutputStream
> ---------------------------------------------
>
>                 Key: HDFS-10905
>                 URL: https://issues.apache.org/jira/browse/HDFS-10905
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client
>    Affects Versions: 2.8.0
>            Reporter: Wei-Chiu Chuang
>            Assignee: Yuanbo Liu
>            Priority: Minor
>
> DataStreamer#createBlockOutputStream and DataStreamer#transfer shared much 
> boilerplate code. HDFS-10609 refactored the transfer method into a 
> StreamerStreams class. The createBlockOutputStream method should reuse the 
> class to de-dup code and to improve code clarity.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to