Anu Engineer commented on HDFS-10558:

I am +1 on this patch, had one clarification question and if you think there is 
no issue we can commit this.

What would happen if an exception was thrown in the plan command during the 
time when we start recording the output and before you print it out the stream.
I am thinking that user would see an exception but not the output of the 
recorded statements, do we need put this in a try..catch and record the 
exception also in the stream and print it out ? or should we just throw and let 
the user lose those statements ? 

Also in the current code fragment the possibility of a runtime exception is 
very low, but I am wondering from a code maintenance standpoint ,  if new code 
is added to that fragment, should we define a formal behavior ? 

> DiskBalancer: Print the full path to  plan file
> -----------------------------------------------
>                 Key: HDFS-10558
>                 URL: https://issues.apache.org/jira/browse/HDFS-10558
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: balancer & mover
>    Affects Versions: HDFS-1312
>            Reporter: Anu Engineer
>            Assignee: Xiaobing Zhou
>            Priority: Minor
>              Labels: newbie
>         Attachments: HDFS-10558-HDFS-1312.000.patch, HDFS-10558.001.patch
> We should print the full path to plan file when plan command is being run. 
> That makes it easy to give that path to -execute option.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to