[
https://issues.apache.org/jira/browse/HDFS-10885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15575448#comment-15575448
]
Rakesh R commented on HDFS-10885:
---------------------------------
Thanks [~zhouwei] for the patch. Please click {{Submit Patch}} button to
trigger the jenkins QA report.
I've few comments,
# IMHO, we can add a check condition to control StoragePolicySatisfier#run(),
so that we could avoid running this thread and verify storage mismatched blocks
if this is disabled.
# Also, there is a configuration to enable storage policy
{{dfs.storage.policy.enabled}}. Perhaps we need to consider combinations
between these two, basically the new configuration can respect this existing
flag.
# How about rephrase message like below, or something better one.
{code}
+ throw new Exception("StoragePolicySatisfier daemon is already running," +
+ " so not allowed to run Mover tool simultaneously.");
{code}
# Instead of this, {code}+ Assert.assertTrue(false);{code} can we
replace with {code}Assert.assertFail("Must throw exception as
StoragePolicySatisfier is already running");{code}
> [SPS]: Mover tool should not be allowed to run when Storage Policy Satisfier
> is on
> ----------------------------------------------------------------------------------
>
> Key: HDFS-10885
> URL: https://issues.apache.org/jira/browse/HDFS-10885
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Reporter: Wei Zhou
> Assignee: Wei Zhou
> Attachments: HDFS-10800-HDFS-10885-00.patch
>
>
> These two can not work at the same time to avoid conflicts and fight with
> each other.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
