[ 
https://issues.apache.org/jira/browse/HDFS-10409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Clampffer updated HDFS-10409:
-----------------------------------
    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Committed to HDFS-8707, thanks for the review [~xiaowei.zhu]!

> libhdfs++: Get rid of lock in RpcConnectionImpl destructor
> ----------------------------------------------------------
>
>                 Key: HDFS-10409
>                 URL: https://issues.apache.org/jira/browse/HDFS-10409
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: James Clampffer
>            Assignee: James Clampffer
>         Attachments: HDFS-10409.HDFS-8707.000.patch, 
> HDFS-10409.HDFS-8707.001.patch, locked_dtor.patch
>
>
> The destructor to RpcConnectionImpl grabs a lock using a std::lock_guard<>.  
> It turns out something is already holding the lock when this happens.  Best 
> bet is something that looks like:
> {code}
> void SomeFunctionThatShouldntTakeLock(){
>   std::lock_guard<std::mutex> bad(connection_state_lock_)
>   conn_.reset(); //conn is a shared_ptr to RpcConnectionImpl
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to