Xiaobing Zhou commented on HDFS-11008:

Thanks for the patch [~liuml07]. You might want to fix the check style issue, 
otherwise, LGTM +1.

> Change unit test for testing parsing "-source" parameter in Balancer CLI
> ------------------------------------------------------------------------
>                 Key: HDFS-11008
>                 URL: https://issues.apache.org/jira/browse/HDFS-11008
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: test
>            Reporter: Mingliang Liu
>            Assignee: Mingliang Liu
>         Attachments: HDFS-11008.000.patch
> [HDFS-8826] added an option {{-source}} to specify the source node list so 
> that balancer only selects blocks to move from those nodes. This is very 
> efficient in some cases.  It also added a new test, 
> testMinBlockSizeAndSourceNodes.
> However, testMinBlockSizeAndSourceNodes does not test {{-source}} option 
> parsing, for both valid and invalid cases.  It builds the parameters directly 
> instead of parsing them from CLI. This JIRA is to track the effort of 
> changing the test for that. In fact, we can refactor the existing code by 
> replacing code that manually creates {{BalancerParameters}} with new code 
> that explores the {{Balancer$Cli#parse()}}.
> Thanks [~jingzhao] for the initial proposal.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to