Wei-Chiu Chuang created HDFS-11018:
--------------------------------------

             Summary: Incorrect check and message in FsDatasetImpl#invalidate
                 Key: HDFS-11018
                 URL: https://issues.apache.org/jira/browse/HDFS-11018
             Project: Hadoop HDFS
          Issue Type: Bug
          Components: datanode
            Reporter: Wei-Chiu Chuang


The following error check and message is incorrect, because {{info}} is null if 
(1) the block id does not exist in ReplicaMap or (2) the generation stamp of 
block does not match the replica entry in ReplicaMap.

{code:title=FsDatasetImpl#invalidate}
       final ReplicaInfo info = volumeMap.get(bpid, invalidBlks[i]);
        if (info == null) {
          // It is okay if the block is not found -- it may be deleted earlier.
          LOG.info("Failed to delete replica " + invalidBlks[i]
              + ": ReplicaInfo not found.");
          continue;
        }
        if (info.getGenerationStamp() != invalidBlks[i].getGenerationStamp()) {
          errors.add("Failed to delete replica " + invalidBlks[i]
              + ": GenerationStamp not matched, info=" + info);
          continue;
        }
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to