[ 
https://issues.apache.org/jira/browse/HDFS-11012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15578085#comment-15578085
 ] 

ASF GitHub Bot commented on HDFS-11012:
---------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/hadoop/pull/142


> Unnecessary INFO logging on DFSClients for InvalidToken
> -------------------------------------------------------
>
>                 Key: HDFS-11012
>                 URL: https://issues.apache.org/jira/browse/HDFS-11012
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 2.5.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Minor
>
> In situations where a DFSClient would receive an InvalidToken exception (as 
> described at [1]), a single retry is automatically made (as observed at [2]). 
> However, we still print an INFO message into the DFSClient's logger even 
> though the message is expected in some scenarios. This should ideally be a 
> DEBUG level message to avoid confusion.
> If the retry or the retried attempt fails, the final clause handles it anyway 
> and prints out a proper WARN (as seen at [3]) so the INFO is unnecessary.
> [1] - 
> https://github.com/apache/hadoop/blob/release-2.7.0/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java#L1330-L1356
> [2] - 
> https://github.com/apache/hadoop/blob/release-2.7.0/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java#L649-L651
>  and 
> https://github.com/apache/hadoop/blob/release-2.7.0/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java#L1163-L1170
> [3] - 
> https://github.com/apache/hadoop/blob/release-2.7.0/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java#L652-L658
>  and 
> https://github.com/apache/hadoop/blob/release-2.7.0/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java#L1171-L1177



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to