[ 
https://issues.apache.org/jira/browse/HDFS-10922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15581622#comment-15581622
 ] 

Weiwei Yang commented on HDFS-10922:
------------------------------------

The UT failure was because 

The TEST_DIR in TestTrash uses 

{code}
private final static Path TEST_DIR =
    new Path(new File(System.getProperty("test.build.data","/tmp")
          ).toURI().toString().replace(' ', '+'), "testTrash");
{code}

instead of (code in branch-2 and trunk)

{code}
 private final static Path TEST_DIR = new Path(GenericTestUtils.getTempPath(
      "testTrash"));
{code}

this will cause the path starts with schema *"file://"*. This will cause this 
var can only be used in local file system, and fail when reusing this in other 
file system. Unfortunately HADOOP-12984 was not committed to branch 2.8. This 
could be easily fixed, do I need another HADOOP ticket or include the fix in a 
new patch here?

> Adding additional unit tests for Trash (II)
> -------------------------------------------
>
>                 Key: HDFS-10922
>                 URL: https://issues.apache.org/jira/browse/HDFS-10922
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: test
>            Reporter: Xiaoyu Yao
>            Assignee: Weiwei Yang
>         Attachments: HDFS-10922-branch-2.01.patch, 
> HDFS-10922-branch-2.8.01.patch, HDFS-10922.02.patch, HDFS-10922.03.patch, 
> HDFS-10922.04.patch, HDFS-10922.05.patch, HDFS-10922.06.patch, 
> HDFS-10922.07.patch, HDFS-10922.08.patch, HDFS-10922.09.patch, 
> HDFS-10922.10.patch, HDFS-10922.11.patch, HDFS-10922.12.patch, 
> HDFS-10922.13.patch
>
>
> This ticket is opened to track adding unit tests for Trash.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to