Erik Krogen updated HDFS-10872:
    Attachment: HDFS-10872.001.patch

Thanks for the review, [~zhz]. 

1. I agree. Created HDFS-11021 to track.
2. Used a {{final String}} variable for each operation whose name is used more 
than once.
3. Per our offline discussion the best place for these metrics to live is 
actually {{FSNamesystem}}'s metrics. Thank you for bringing up the issue.

Attaching v001 patch with the above changes and some bug fixes. 

> Add MutableRate metrics for FSNamesystemLock operations
> -------------------------------------------------------
>                 Key: HDFS-10872
>                 URL: https://issues.apache.org/jira/browse/HDFS-10872
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Erik Krogen
>            Assignee: Erik Krogen
>         Attachments: FSLockPerf.java, HDFS-10872.000.patch, 
> HDFS-10872.001.patch
> Add metrics for FSNamesystemLock operations to see, overall, how long each 
> operation is holding the lock for. Use MutableRate metrics for now. 

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to