Erik Krogen commented on HDFS-11021:

Currently the {{BlockManager}} only uses the {{Namesystem}} interface, which 
inherits all of its locking methods from the {{RwLock}} interface. 
{{Namesystem}} is the only implementer of that interface. For the 
{{BlockManager}} to emit lock hold time metrics, it needs access to the 
{{read/writeUnlock(String operationName)}} methods on {{FSNamesystem}}. We have 
two options: adding these methods to the {{Namesystem}} interface, or to the 
{{RwLock}} interface. It may make sense to group all of the locking-related 
methods together in {{RwLock}}, but this may be polluting that interface. Any 
thoughts on this?

> Add FSNamesystemLock metrics for BlockManager operations
> --------------------------------------------------------
>                 Key: HDFS-11021
>                 URL: https://issues.apache.org/jira/browse/HDFS-11021
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Erik Krogen
>            Assignee: Erik Krogen
> Right now the operations which the {{BlockManager}} issues to the 
> {{Namesystem}} will not emit metrics about which operation caused the 
> {{FSNamesystemLock}} to be held; they are all grouped under "OTHER". We 
> should fix this since the {{BlockManager}} creates many acquisitions of both 
> the read and write locks. 

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to