Hanisha Koneru updated HDFS-10906:
    Attachment: HDFS-10906.003.patch

Thank you [~xyao] for reviewing the patch. 

The Path constructor _public Path(Path parent, String child)_ resolves the 
parent path to only the scheme and authority. The path component is removed. 
For example, 
Path p1 = new Path("hdfs://localhost:54995/user/hdfs/.Trash/Current”);
Path p2 = new Path("/zone4/encFile3”);
Path p = new Path(p1, p2) 
would resolve _path p_ to "hdfs://localhost:55234/zone4/encFile3".
Thats why I used mergePaths to retain the path component in parent path. The 
other option would be to remove the leading SEPARATOR ("/") from the child path 
and then use the Path constructor.

I have fixed the other issues in patch v3.

> Add unit tests for Trash with HDFS encryption zones
> ---------------------------------------------------
>                 Key: HDFS-10906
>                 URL: https://issues.apache.org/jira/browse/HDFS-10906
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: encryption
>    Affects Versions: 2.8.0
>            Reporter: Xiaoyu Yao
>            Assignee: Hanisha Koneru
>         Attachments: HDFS-10906.000.patch, HDFS-10906.001.patch, 
> HDFS-10906.002.patch, HDFS-10906.003.patch
> The goal is to improve unit test coverage for HDFS trash with encryption zone 
> especially under Kerberos environment. The current unit test 
> TestEncryptionZones#testEncryptionZonewithTrash() has limited coverage on 
> non-Kerberos case.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to