[ 
https://issues.apache.org/jira/browse/HDFS-11025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15585455#comment-15585455
 ] 

Eric Badger commented on HDFS-11025:
------------------------------------

bq. Since there is no other operations after restarting datanodes, I think this 
change will not influence the current logic,
This test uses a single @BeforeClass annotation to start up the mini cluster. 
So there *are* operations after restarting datanodes, just not in the specific 
test that you are running. That being said, the subsequent tests don't know or 
care what port the datanodes are on for the previous test, they just require 
that a mini cluster is up and running. So I agree that we can just start the 
datanodes back up on different ports.

> TestDiskspaceQuotaUpdate fails in trunk
> ---------------------------------------
>
>                 Key: HDFS-11025
>                 URL: https://issues.apache.org/jira/browse/HDFS-11025
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Yiqun Lin
>            Assignee: Yiqun Lin
>            Priority: Minor
>         Attachments: HDFS-11025.001.patch
>
>
> The test {{TestDiskspaceQuotaUpdate}} fails sometimes after HDFS-10843, the 
> link addresse: 
> https://builds.apache.org/job/PreCommit-HDFS-Build/17200/testReport/. The 
> stack infos:
> {code} 
> java.net.BindException: Problem binding to [localhost:49195] 
> java.net.BindException: Address already in use; For more details see:  
> http://wiki.apache.org/hadoop/BindException
> {code} 
> I found the bind exception was happened in new test method 
> {{TestDiskspaceQuotaUpdate.testQuotaIssuesWhileCommitting}}. The related 
> codes:
> {code}
>   public void testQuotaIssuesWhileCommitting() throws Exception {
>     ...
>     try {
>       for (int i = REPLICATION - 1; i > 0; i--) {
>         dnprops.add(cluster.stopDataNode(i));
>       }
>       ...
>     } finally {
>       for (MiniDFSCluster.DataNodeProperties dnprop : dnprops) {
>         cluster.restartDataNode(dnprop, true);
>       }
>       cluster.waitActive();
>     }
>   }
> {code}
> I think we can make a simple fix in {{cluster.restartDataNode(dnprop, 
> true);}}. Since there is no other operations after restarting datanodes, I 
> think this change will not influence the current logic,



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to