Zhe Zhang commented on HDFS-10872:

Thanks Erik! The v3 patch LGTM. +1 pending fixing the long line checkstyle 
* {@link 

I think we should leave the try-and-backoff as a potential optimization.

I will hold off committing the patch until EOD Thursday to collect more 
feedbacks. [~kihwal] Do you think the patch addresses your [use cases | 
 [~andrew.wang] Do you think the aggregation method addresses your concern on 
performance (see benchmark above)? [~liuml07] Any comments on the form of 

> Add MutableRate metrics for FSNamesystemLock operations
> -------------------------------------------------------
>                 Key: HDFS-10872
>                 URL: https://issues.apache.org/jira/browse/HDFS-10872
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Erik Krogen
>            Assignee: Erik Krogen
>         Attachments: FSLockPerf.java, HDFS-10872.000.patch, 
> HDFS-10872.001.patch, HDFS-10872.002.patch, HDFS-10872.003.patch
> Add metrics for FSNamesystemLock operations to see, overall, how long each 
> operation is holding the lock for. Use MutableRate metrics for now. 

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to