[ 
https://issues.apache.org/jira/browse/HDFS-8410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15590592#comment-15590592
 ] 

SammiChen commented on HDFS-8410:
---------------------------------

Hi Andrew, thanks for the comments. Yea, It's better to use "final" for the new 
variable. Regarding using {{Time.monotonicNow()}} function, it seems this 
function returns the millisecond value instead of nanoseconds value. Given this 
metric is called "Nanoseconds spent by decoding tasks", I'm not sure if you are 
suggesting change this metric definition to "Milliseconds" something. I'd like 
to known your opinion. 

> Add computation time metrics to datanode for ECWorker
> -----------------------------------------------------
>
>                 Key: HDFS-8410
>                 URL: https://issues.apache.org/jira/browse/HDFS-8410
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Li Bo
>            Assignee: SammiChen
>         Attachments: HDFS-8410-001.patch, HDFS-8410-002.patch, 
> HDFS-8410-003.patch, HDFS-8410-004.patch
>
>
> This is a sub task of HDFS-7674. It adds time metric for ec decode work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to