[
https://issues.apache.org/jira/browse/HDFS-11045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15603161#comment-15603161
]
Xiao Chen commented on HDFS-11045:
----------------------------------
Thanks [~templedf] for working on this.
For the record, this is the console output before the failure:
{noformat}
2016-10-22 08:09:27,439 [Thread-1032] INFO datanode.TestDirectoryScanner
(TestDirectoryScanner.java:testThrottling(693)) - Scanner took 0ms to shutdown
2016-10-22 08:09:27,439 [Thread-1032] INFO datanode.TestDirectoryScanner
(TestDirectoryScanner.java:testThrottling(708)) - RATIO: 9.652174
{noformat}
So I think for this specific failure, it seems not to be the case about the
final ratio (which would go higher).
But a running average sounds like a great idea, and would definitely help to
reduce false alarms. Some review comments:
- Extra line-break in import. We should also move the {{com.google}} import
next to the current one.
- Is {{DirectoryScanner#calculateRatio}} only for tests? Would like to disable
it by default then.
> TestDirectoryScanner#testThrottling fails: Throttle is too permissive
> ---------------------------------------------------------------------
>
> Key: HDFS-11045
> URL: https://issues.apache.org/jira/browse/HDFS-11045
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Affects Versions: 3.0.0-alpha2
> Reporter: John Zhuge
> Assignee: Daniel Templeton
> Priority: Minor
> Attachments: HDFS-11045.001.patch
>
>
> TestDirectoryScanner.testThrottling:709 Throttle is too permissive
> https://builds.apache.org/job/PreCommit-HDFS-Build/17259/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
