[
https://issues.apache.org/jira/browse/HDFS-10756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15606653#comment-15606653
]
Xiao Chen commented on HDFS-10756:
----------------------------------
Thanks for revving. Patch looks good.
Some comments:
- Let's add coverage in {{TestEncryptionZones}} for nested EZ. I see {{/}} is
covered now, which is great. :)
- {{HttpFSFileSystem.java}}: {{Map<String, String> params = new HashMap<String,
String>();}} can leave out the type and instantiate the HashMap with a diamond
operator {{<>}}
Also, some of my earlier comments still need to be addressed:
{quote}
- NamenodeWebHdfsMethods
Please stick with current coding style. Needs '{}' to wrap the case block.
- we should add docs in this patch (to WebHDFS.md for example).
{quote}
> Expose getTrashRoot to HTTPFS and WebHDFS
> -----------------------------------------
>
> Key: HDFS-10756
> URL: https://issues.apache.org/jira/browse/HDFS-10756
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: encryption, httpfs, webhdfs
> Reporter: Xiao Chen
> Assignee: Yuanbo Liu
> Attachments: HDFS-10756.001.patch, HDFS-10756.002.patch,
> HDFS-10756.003.patch
>
>
> Currently, hadoop FileSystem API has
> [getTrashRoot|https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java#L2708]
> to determine trash directory at run time. Default trash dir is under
> {{/user/$USER}}
> For an encrypted file, since moving files between/in/out of EZs are not
> allowed, when an EZ file is deleted via CLI, it calls in to [DFS
> implementation|https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java#L2485]
> to move the file to a trash directory under the same EZ.
> This works perfectly fine for CLI users or java users who call FileSystem
> API. But for users via httpfs/webhdfs, currently there is no way to figure
> out what the trash root would be. This jira is proposing we add such
> interface to httpfs and webhdfs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
